From 202aab8e63e71c34846a9d51135fd4782c2bdb49 Mon Sep 17 00:00:00 2001 From: gaoren002 Date: Mon, 11 May 2026 21:49:40 +0000 Subject: [PATCH] fix(accounts): unschedule errored accounts --- backend/internal/repository/account_repo.go | 7 ++++++- .../account_repo_integration_test.go | 18 +++++++++++++++++- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/backend/internal/repository/account_repo.go b/backend/internal/repository/account_repo.go index 78f739ac..5d7ff70d 100644 --- a/backend/internal/repository/account_repo.go +++ b/backend/internal/repository/account_repo.go @@ -317,6 +317,10 @@ func (r *accountRepository) Update(ctx context.Context, account *service.Account if account == nil { return nil } + schedulable := account.Schedulable + if account.Status == service.StatusError { + schedulable = false + } builder := r.client.Account.UpdateOneID(account.ID). SetName(account.Name). @@ -329,7 +333,7 @@ func (r *accountRepository) Update(ctx context.Context, account *service.Account SetPriority(account.Priority). SetStatus(account.Status). SetErrorMessage(account.ErrorMessage). - SetSchedulable(account.Schedulable). + SetSchedulable(schedulable). SetAutoPauseOnExpired(account.AutoPauseOnExpired) if account.RateMultiplier != nil { @@ -716,6 +720,7 @@ func (r *accountRepository) SetError(ctx context.Context, id int64, errorMsg str Where(dbaccount.IDEQ(id)). SetStatus(service.StatusError). SetErrorMessage(errorMsg). + SetSchedulable(false). Save(ctx) if err != nil { return err diff --git a/backend/internal/repository/account_repo_integration_test.go b/backend/internal/repository/account_repo_integration_test.go index d1cea9eb..87ed49ca 100644 --- a/backend/internal/repository/account_repo_integration_test.go +++ b/backend/internal/repository/account_repo_integration_test.go @@ -729,7 +729,7 @@ func (s *AccountRepoSuite) TestUpdateLastUsed() { // --- SetError --- func (s *AccountRepoSuite) TestSetError() { - account := mustCreateAccount(s.T(), s.client, &service.Account{Name: "acc-err", Status: service.StatusActive}) + account := mustCreateAccount(s.T(), s.client, &service.Account{Name: "acc-err", Status: service.StatusActive, Schedulable: true}) s.Require().NoError(s.repo.SetError(s.ctx, account.ID, "something went wrong")) @@ -737,6 +737,22 @@ func (s *AccountRepoSuite) TestSetError() { s.Require().NoError(err) s.Require().Equal(service.StatusError, got.Status) s.Require().Equal("something went wrong", got.ErrorMessage) + s.Require().False(got.Schedulable) +} + +func (s *AccountRepoSuite) TestUpdateErrorStatusUnschedulesAccount() { + account := mustCreateAccount(s.T(), s.client, &service.Account{Name: "acc-update-err", Status: service.StatusActive, Schedulable: true}) + account.Status = service.StatusError + account.ErrorMessage = "token revoked" + account.Schedulable = true + + s.Require().NoError(s.repo.Update(s.ctx, account)) + + got, err := s.repo.GetByID(s.ctx, account.ID) + s.Require().NoError(err) + s.Require().Equal(service.StatusError, got.Status) + s.Require().Equal("token revoked", got.ErrorMessage) + s.Require().False(got.Schedulable) } func (s *AccountRepoSuite) TestClearError_SyncSchedulerSnapshotOnRecovery() {