sub2api/backend/internal/service/oauth_refresh_api_singleflight_test.go

//go:build unit

package service

import (
	"context"
	"sync"
	"sync/atomic"
	"testing"
	"time"

	"github.com/stretchr/testify/require"
)

// blockingExecutor 在 Refresh 中等待 release 信号，便于精确控制并发时序。
type blockingExecutor struct {
	refreshAPIExecutorStub
	release      chan struct{}
	concurrent   int32 // 当前正在 Refresh 的 goroutine 数
	maxObserved  int32 // 观察到的最大并发数
	calls        int32
}

func (e *blockingExecutor) Refresh(_ context.Context, _ *Account) (map[string]any, error) {
	atomic.AddInt32(&e.calls, 1)
	c := atomic.AddInt32(&e.concurrent, 1)
	for {
		old := atomic.LoadInt32(&e.maxObserved)
		if c <= old || atomic.CompareAndSwapInt32(&e.maxObserved, old, c) {
			break
		}
	}
	defer atomic.AddInt32(&e.concurrent, -1)

	<-e.release
	return e.credentials, e.err
}

func TestOAuthRefreshAPI_SingleflightDedupesConcurrentCallers(t *testing.T) {
	// 同一 cacheKey 同时进入 N 个 goroutine，应只触发 1 次 executor.Refresh。
	repo := &refreshAPIAccountRepo{account: &Account{ID: 42, Platform: "claude"}}
	cache := &refreshAPICacheStub{lockResult: true}

	exec := &blockingExecutor{
		refreshAPIExecutorStub: refreshAPIExecutorStub{
			needsRefresh: true,
			credentials:  map[string]any{"access_token": "new"},
		},
		release: make(chan struct{}),
	}

	api := NewOAuthRefreshAPI(repo, cache)

	const callers = 20
	results := make([]*OAuthRefreshResult, callers)
	errs := make([]error, callers)
	var wg sync.WaitGroup
	wg.Add(callers)

	for i := 0; i < callers; i++ {
		i := i
		go func() {
			defer wg.Done()
			r, err := api.RefreshIfNeeded(context.Background(), &Account{ID: 42, Platform: "claude"}, exec, 5*time.Minute)
			results[i] = r
			errs[i] = err
		}()
	}

	// 等所有 goroutine 都进入 sf 闭包，确保它们集中在同一窗口里抢同一 key。
	deadline := time.Now().Add(2 * time.Second)
	for atomic.LoadInt32(&exec.concurrent) == 0 && time.Now().Before(deadline) {
		time.Sleep(10 * time.Millisecond)
	}
	require.Equal(t, int32(1), atomic.LoadInt32(&exec.concurrent), "singleflight should serialize callers into one Refresh")

	close(exec.release)
	wg.Wait()

	require.Equal(t, int32(1), atomic.LoadInt32(&exec.calls), "executor.Refresh must be called exactly once")
	require.Equal(t, int32(1), atomic.LoadInt32(&exec.maxObserved), "no two goroutines should be inside Refresh simultaneously")

	// 所有 caller 应拿到等价结果（不必同实例，singleflight Shared 标志会让多个 caller 共享）。
	for i := 0; i < callers; i++ {
		require.NoError(t, errs[i])
		require.NotNil(t, results[i])
		require.True(t, results[i].Refreshed)
	}
}

func TestOAuthRefreshAPI_SingleflightSeparatesDifferentCacheKeys(t *testing.T) {
	// 不同账号有不同 cacheKey，应能并行刷新而非互相阻塞。
	repo := &refreshAPIAccountRepo{account: &Account{ID: 1, Platform: "claude"}}
	cache := &refreshAPICacheStub{lockResult: true}

	exec := &blockingExecutor{
		refreshAPIExecutorStub: refreshAPIExecutorStub{
			needsRefresh: true,
			credentials:  map[string]any{"access_token": "new"},
		},
		release: make(chan struct{}),
	}

	api := NewOAuthRefreshAPI(repo, cache)

	var wg sync.WaitGroup
	for i := 0; i < 3; i++ {
		platform := "p" + string(rune('a'+i))
		wg.Add(1)
		go func() {
			defer wg.Done()
			_, _ = api.RefreshIfNeeded(context.Background(), &Account{ID: 1, Platform: platform}, exec, 5*time.Minute)
		}()
	}

	deadline := time.Now().Add(2 * time.Second)
	for atomic.LoadInt32(&exec.concurrent) < 3 && time.Now().Before(deadline) {
		time.Sleep(10 * time.Millisecond)
	}
	require.Equal(t, int32(3), atomic.LoadInt32(&exec.maxObserved), "different cacheKeys should run in parallel")

	close(exec.release)
	wg.Wait()
}

func TestOAuthRefreshAPI_SingleflightSeparatesDifferentRefreshWindows(t *testing.T) {
	// 同 cacheKey 但不同 refreshWindow（前台短窗口 vs 后台长窗口）应分开判断
	// NeedsRefresh，避免后台长窗口的"已经在刷"让前台短窗口拿到旧值。
	repo := &refreshAPIAccountRepo{account: &Account{ID: 42, Platform: "claude"}}
	cache := &refreshAPICacheStub{lockResult: true}

	exec := &blockingExecutor{
		refreshAPIExecutorStub: refreshAPIExecutorStub{
			needsRefresh: true,
			credentials:  map[string]any{"access_token": "new"},
		},
		release: make(chan struct{}),
	}
	api := NewOAuthRefreshAPI(repo, cache)

	var wg sync.WaitGroup
	wg.Add(2)
	go func() {
		defer wg.Done()
		_, _ = api.RefreshIfNeeded(context.Background(), &Account{ID: 42, Platform: "claude"}, exec, 5*time.Minute)
	}()
	go func() {
		defer wg.Done()
		_, _ = api.RefreshIfNeeded(context.Background(), &Account{ID: 42, Platform: "claude"}, exec, 1*time.Hour)
	}()

	deadline := time.Now().Add(2 * time.Second)
	for atomic.LoadInt32(&exec.concurrent) < 2 && time.Now().Before(deadline) {
		time.Sleep(10 * time.Millisecond)
	}
	require.Equal(t, int32(2), atomic.LoadInt32(&exec.maxObserved), "different refreshWindow should not be merged")

	close(exec.release)
	wg.Wait()
}